Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Inconsistent tests (due to timeout?) #356

Closed
chrisfosterelli opened this issue Jan 16, 2018 · 2 comments
Closed

Inconsistent tests (due to timeout?) #356

chrisfosterelli opened this issue Jan 16, 2018 · 2 comments
Labels

Comments

@chrisfosterelli
Copy link
Member

chrisfosterelli commented Jan 16, 2018

Some of the builds are failing on semaphore periodically, from looking at the logs I think it's related to this test.

What could be happening is that the test is taking longer than 500ms on semaphore, the default timeout for tape, and then it is reporting the error that only 1 condition finished while 3 were expected. There is an open issue for tape that seems very similar to our output in semaphore.

@chrisfosterelli
Copy link
Member Author

This doesn't seem to be related to timing, but the promise was actually being rejected. I can't replicate locally and it doesn't seem to happen anymore on semaphore so I'll assume it was a transient problem on their side.

@chrisfosterelli
Copy link
Member Author

Cleaned up all the dependencies by:

Merging #357.
Merging #359.
Closing #355 via #360.
Closing #354 via #361.
Closing #358.
Merging #362.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant