Adhere more strictly to bins
argument in stat_bin()
#5891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5882, fix #5036 and fix #5890.
Briefly, the default
boundary
was sometimes imputed such thatbins
was not respected.This PR fixes that by setting the default
boundary
half a bin below the minimum.The reason why this value was chosen is utilitarian rather than having good theoretical justification.
It only affects the arm of the binning code that deals with unspecified
binwidth
orbreaks
arguments.As #5890 had adjacent code, I decided to fix that here as well.
The relevant reprexes:
Created on 2024-05-13 with reprex v2.1.0