Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixer does not fix TLint warning about global_namespace_import #125

Closed
machacekmartin opened this issue Sep 2, 2023 · 1 comment · Fixed by #146
Closed

Fixer does not fix TLint warning about global_namespace_import #125

machacekmartin opened this issue Sep 2, 2023 · 1 comment · Fixed by #146
Labels
enhancement New feature or request

Comments

@machacekmartin
Copy link

After installing duster with no custom config whatsoever - the command ./vendor/bin/duster lint successfully highlights errors regarding global_namespace_import rule (under Linting using TLint section), but running ./vendor/bin/duster fix does not actually fix these imports.

Example:

Forms\Components\Fieldset::make('General information')

this is marked with Fully Qualified Class Names should only be used for accessing class names warning, but the ./vendor/bin/duster fix command doesnt fix it. it just goes LGTM!

@driftingly
Copy link
Member

driftingly commented Sep 2, 2023

TLint doesn't fix this linting issue. I looked into it but couldn't find a way to do it reliably. There are too many edge cases having to do with name collisions.

I'll leave this open for now as I consider a solution related to #124 where, if TLint discovers a listing issue, the fix command still fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants