Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g2p-seq2seq is deprecated. #40

Open
b00f opened this issue Feb 14, 2020 · 6 comments
Open

g2p-seq2seq is deprecated. #40

b00f opened this issue Feb 14, 2020 · 6 comments

Comments

@b00f
Copy link
Member

b00f commented Feb 14, 2020

g2p-seq2seq using python 2.7 which is deprecated now. There is an open issue in g2p-seq2seq about this: cmusphinx/g2p-seq2seq#177

Updating the g2p-seq2seq is not easy since it uses tensorflow and tensorflow is known for unsuitability and changing the codebase.
I emailed Nickolay who is maintaining this project and talk about this issue. here is his response:

Hello Mostafa

Nice to meet you here. I've been following your project for quite some time actually, it is a great undertaking.

I do not have the plans to keep the project alive, you might take over it if you want. I'll just add you as developers.

As for future development, I given up on Tensorflow as industry also left it. Everyone is on Pytorch nowadays. Tensorflow really screwed it with unclear API and frequent changes which break everything. 1.10 is different from 1.12 and so on and so forth. You can also read comments here: https://news.ycombinator.com/item?id=21118018

I'm planning to move to Pytorch and use maybe fairseq or a different seq2seq framework in Pytorch, but that will take some work which I don't have time to do right now. Feel free to jump in and let me know if you have further questions.

We have two options:

@mohamad-hasan-sohan-ajini
Copy link
Collaborator

@boof

If there is any plan to move toward pytorch, I'll be in!

@b00f
Copy link
Member Author

b00f commented Feb 17, 2020

You can fork the g2p-seq2sea project and update the project. Here is Nikolay's email address: nshmyrev@gmail.com. @nshmyrev is maintaining the g2p-seq2seq. He knew about our project. You can directly contact him. I am sure he will help you in this matter.

@mohamad-hasan-sohan-ajini
Copy link
Collaborator

A step closer to upgrade tihu G2P...

Check this repo out and suggest any consideration I should be aware for developing tihu G2P.

regards

@b00f
Copy link
Member Author

b00f commented Mar 9, 2020

This is awesome. Good to hear you are working on that. Thanks

@mohamad-hasan-sohan-ajini
Copy link
Collaborator

Now, G2P supports multilingual grapheme to phoneme training.
Time to fork g2p-seq2seq...

@b00f
Copy link
Member Author

b00f commented Mar 15, 2020

I add @ebraminio to this thread. He might be interested to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants