Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_backup: fix panic when encountered error during resuming #17021

Merged
merged 2 commits into from
May 16, 2024
Merged

log_backup: fix panic when encountered error during resuming #17021

merged 2 commits into from
May 16, 2024

Conversation

YuJuncen
Copy link
Contributor

What is changed and how it works?

Issue Number: Close #17020

What's Changed:

Spawn thread from the thread pool directly. (Instead of the thread local runtime handle.)

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that might cause TiKV panic when resuming a PiTR task and the connection to PD isn't stable enought.

@YuJuncen
fix panic when encountered error during resuming
805e611 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 15, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 15, 2024
@YuJuncen
make clippy happy
168d018 
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 15, 2024
@3pointer 3pointer removed the status/LGT2 Status: PR - There are already 2 approvals label May 15, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT2 Status: PR - There are already 2 approvals label May 15, 2024
@YuJuncen
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

@YuJuncen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 168d018

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9d0d995 into tikv:master May 16, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone May 16, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17025.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request May 16, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#17021
da19903 
close tikv#17020

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2024
Merged
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17026.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request May 16, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#17021
daaa39f 
close tikv#17020

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2024
Open
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17027.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request May 16, 2024
@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#17021
0b700bf 
close tikv#17020

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2024
Open
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17028.

@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 20, 2024
@ti-chi-bot @YuJuncen
log_backup: fix panic when encountered error during resuming (#17021) (…
ba73b0d 
…#17028)

close #17020

Spawn thread from the thread pool directly. (Instead of the thread local runtime handle.)

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: hillium <yujuncen@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2024
@ti-chi-bot @YuJuncen
log_backup: fix panic when encountered error during resuming (#17021) (…
97b4b5d 
…#17025)

close #17020

Spawn thread from the thread pool directly. (Instead of the thread local runtime handle.)

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Yu Juncen <yu745514916@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 needs-cherry-pick-release-7.5 needs-cherry-pick-release-8.1 release-note size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

tikv panic due to: there is no reactor running, must be called from the context of a Tokio 1.x runtime
4 participants
@YuJuncen @ti-chi-bot @glorv @3pointer