Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Extraneous output ({}) when running BuildTask #113

Open
chancancode opened this issue Aug 29, 2017 · 1 comment
Open

Extraneous output ({}) when running BuildTask #113

chancancode opened this issue Aug 29, 2017 · 1 comment

Comments

@chancancode
Copy link
Member

I believe this line is intended for printing the command we are about to execute. However, when called in this form it causes the console output to look like this:

{}
cargo rustc --release -- -C link-args=-Wl,-undefined,dynamic_lookup

...or sometimes...

{"HELIX_LIB_DIR"=>"/Users/godfrey/Code/helix/ruby/windows_build"}
cargo rustc --release -- -C link-args=-Wl,-undefined,dynamic_lookup
@wagenet
Copy link
Collaborator

wagenet commented Aug 29, 2017

The system command can take a hash of ENV variables. However, when we're empty it prints an empty hash. We could probably make the run method signature run(env, cmd) and then only print env if it isn't empty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants