New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont round off floats while formatting #679
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=======================================
- Coverage 97.8% 97.7% -0.0%
=======================================
Files 81 82 +1
Lines 9378 9110 -268
=======================================
- Hits 9169 8905 -264
+ Misses 209 205 -4 ☔ View full report in Codecov by Sentry. |
@@ -40,6 +41,31 @@ const WEEKDAY_NAMES: [&[u8]; 7] = [ | |||
b"Sunday", | |||
]; | |||
|
|||
/// Wrapper struct for f64 with custom Display formatter | |||
#[derive(Debug, Clone, Copy)] | |||
pub struct FloatNum(f64); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this public for tests
@jhpratt Any updates on this? We are kind of blocked on this |
Sorry, this fell through the cracks. I'll take a look soon, though I'll likely want to make some changes myself to avoid exposing anything unnecessarily. |
Sure thanks let me know that the changes are |
Fixes #678