Fix telemetry stats regression test #6907
Merged
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
fix_telemetry_stats_flaky_test
branch
from
d478198
to
0a549ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6907 +/- ##
==========================================
+ Coverage 80.06% 80.88% +0.81%
==========================================
Files 190 199 +9
Lines 37181 37193 +12
Branches 9450 9703 +253
==========================================
+ Hits 29770 30082 +312
- Misses 2997 3233 +236
+ Partials 4414 3878 -536 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
fix_telemetry_stats_flaky_test
branch
from
0a549ee
to
13de751
Compare
fabriziomello
changed the title
fabriziomello
force-pushed
the
fix_telemetry_stats_flaky_test
branch
from
13de751
to
64e822b
Compare
fabriziomello
force-pushed
the
fix_telemetry_stats_flaky_test
branch
2 times, most recently
from
875377f
to
8861c6c
Compare
svenklemm
approved these changes
May 15, 2024
fabriziomello
force-pushed
the
fix_telemetry_stats_flaky_test
branch
from
8861c6c
to
c0f68d1
Compare
In timescale#6767 we introduced the track job execution history and renamed the `policy_job_error_retention` to `policy_job_stat_history_retention` but we forgot to adapt the telemetry to identify this change. Fixes timescale#6898
fabriziomello
force-pushed
the
fix_telemetry_stats_flaky_test
branch
from
c0f68d1
to
a35f139
Compare
gayyappan
approved these changes
May 15, 2024
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
May 16, 2024
In timescale#6907 we supposed to fix the telemetry stats regression test flakiness but unfortutanely it was not enough. What happens is when the regression test runner setup the database for regression tests be executed we stop the scheduler and if for some reason a system job is running then it will be killed and it produces records on `bgw_job_stat` and `bgw_job_stat_history` with the crash information that can potentially lead to flaky test output. To prevent it we cleanup system job stats metadata table just after stop the scheduler.
fabriziomello
added a commit
that referenced
this pull request
May 17, 2024
In #6907 we supposed to fix the telemetry stats regression test flakiness but unfortutanely it was not enough. What happens is when the regression test runner setup the database for regression tests be executed we stop the scheduler and if for some reason a system job is running then it will be killed and it produces records on `bgw_job_stat` and `bgw_job_stat_history` with the crash information that can potentially lead to flaky test output. To prevent it we cleanup system job stats metadata table just after stop the scheduler.
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
In #6907 we supposed to fix the telemetry stats regression test flakiness but unfortutanely it was not enough. What happens is when the regression test runner setup the database for regression tests be executed we stop the scheduler and if for some reason a system job is running then it will be killed and it produces records on `bgw_job_stat` and `bgw_job_stat_history` with the crash information that can potentially lead to flaky test output. To prevent it we cleanup system job stats metadata table just after stop the scheduler. (cherry picked from commit c717792)
fabriziomello
added a commit
that referenced
this pull request
May 17, 2024
In #6907 we supposed to fix the telemetry stats regression test flakiness but unfortutanely it was not enough. What happens is when the regression test runner setup the database for regression tests be executed we stop the scheduler and if for some reason a system job is running then it will be killed and it produces records on `bgw_job_stat` and `bgw_job_stat_history` with the crash information that can potentially lead to flaky test output. To prevent it we cleanup system job stats metadata table just after stop the scheduler. (cherry picked from commit c717792)
fabriziomello
added a commit
that referenced
this pull request
May 17, 2024
In #6907 we supposed to fix the telemetry stats regression test flakiness but unfortutanely it was not enough. What happens is when the regression test runner setup the database for regression tests be executed we stop the scheduler and if for some reason a system job is running then it will be killed and it produces records on `bgw_job_stat` and `bgw_job_stat_history` with the crash information that can potentially lead to flaky test output. To prevent it we cleanup system job stats metadata table just after stop the scheduler. (cherry picked from commit c717792)
timescale-automation
pushed a commit
that referenced
this pull request
May 17, 2024
In #6907 we supposed to fix the telemetry stats regression test flakiness but unfortutanely it was not enough. What happens is when the regression test runner setup the database for regression tests be executed we stop the scheduler and if for some reason a system job is running then it will be killed and it produces records on `bgw_job_stat` and `bgw_job_stat_history` with the crash information that can potentially lead to flaky test output. To prevent it we cleanup system job stats metadata table just after stop the scheduler. (cherry picked from commit c717792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6767 we introduced the track job execution history and renamed the
policy_job_error_retentiontopolicy_job_stat_history_retentionbut we forgot to adapt the telemetry to identify this change.Fixes #6898
Disable-check: force-changelog-file