Improve support of non-relative imports in projects with a baseUrl #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded yargs - Upgraded min nodejs version to 14 - Changed target from es5 to es2020
…e baseUrl - Used `resolveReferencedModule` helper to check whether a referenced module is external or internal - Refactored generating output and now we're using compiler's API to deal with modifiers
timocov
force-pushed
the
fix-module-resolution-with-non-relative-imports
branch
from
ad68bf2
to
f55b2f1
Compare
In fact, migrating Node.modifiers usage
timocov
force-pushed
the
fix-module-resolution-with-non-relative-imports
branch
from
c25857e
to
76c6ba7
Compare
|
Thanks @timocov 🎉🎉 |
|
The fix has been released in v7.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally created by @josh- in #219, but the changes needed some additional work so here it is.
I rebased Josh's changes on the latest repo state and added fixed on top of that.
This PR includes the following breaking changes:
yargswas upgraded from 17.2 to 17.6Fixes #219