Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--external-inlines doesn't bundle completely #234

Closed
pofulu opened this issue Jan 24, 2023 · 1 comment · Fixed by #235
Closed

--external-inlines doesn't bundle completely #234

pofulu opened this issue Jan 24, 2023 · 1 comment · Fixed by #235
Assignees
Labels
Milestone

Comments

@pofulu
Copy link

pofulu commented Jan 24, 2023

Bug report

The --external-inlines not bundle all used types.

Input code

import { Subject } from "rxjs";

const subject = new Subject<void>();

// This should return `Observable<void>
export function onEvent() {  
  return subject.asObservable();
}

Expected output

The Observable<void> should be inlined, no need to import rxjs package.

// ...All inline types
export declare function onEvent(): Observable<void>;
export {};

Actual output

But Observable still not be inlined, and need to import rxjs package.

// ...All inline types
export declare function onEvent(): import("rxjs").Observable<void>;
export {};

Additional context

I use the following command to bundle:

pnpm dts-bundle-generator ./src/app.ts --external-inlines 'rxjs'
@timocov
Copy link
Owner

timocov commented Jan 28, 2023

@pofulu thanks for reporting! The fix has been released in v7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants