Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare module Module statements from dependencies are inlined despite if it should be imported #250

Closed
HarelM opened this issue Apr 14, 2023 · 3 comments
Assignees
Labels

Comments

@HarelM
Copy link

HarelM commented Apr 14, 2023

Bug report

Input code

We have a huge library - maplibre-gl-js that uses this tool.

Expected output

No errors - it used to pass for version 7.2

Actual output

A lot of errors:
See here:
https://github.com/maplibre/maplibre-gl-js/actions/runs/4695006196/jobs/8323730861?pr=2338
in the build-dist:
image

Additional context
I was trying my best to make sure I follow the rules defined in this tool to make sure we are able to generate d.ts files from the ts code of maplibre, we are using CI tools to make sure everything is checked and a dependabot CI failed after the release of version 8.
See here:
maplibre/maplibre-gl-js#2338

Thanks for all the hard work invested in this tool!

Thanks!

@timocov
Copy link
Owner

timocov commented Apr 14, 2023

Ah that's a nice one! It is related to the following breaking change

Changed default behavior for module ModuleName statements (without quotes) (see #237 and #242)

but definitely it is a bug. I'll fix it shortly.

@timocov timocov added the Bug label Apr 14, 2023
@timocov timocov self-assigned this Apr 14, 2023
@timocov timocov changed the title A lot of errors started to appear when trying to migrate to version 8 declare module Module statements from dependencies are inlined despite if it should be imported Apr 14, 2023
@timocov
Copy link
Owner

timocov commented Apr 14, 2023

The fix has been published in v8.0.1.

@HarelM
Copy link
Author

HarelM commented Apr 15, 2023

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants