Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new chart type]: combined chart #22

Open
Dkalugin opened this issue Sep 3, 2019 · 3 comments
Open

[new chart type]: combined chart #22

Dkalugin opened this issue Sep 3, 2019 · 3 comments

Comments

@Dkalugin
Copy link

Dkalugin commented Sep 3, 2019

Issuehunt badges

Hello!
Can I build a combined chart like a screenshot?
https://tetis-capital.ru/upload/image/chart.png


IssueHunt Summary

Backers (Total: $50.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@timqian timqian changed the title Question new chart type: combined chart Sep 3, 2019
@timqian timqian added this to the v1.2 milestone Sep 3, 2019
@timqian timqian changed the title new chart type: combined chart [new chart type]: combined chart Sep 3, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 4, 2019

@issuehunt has funded $50.00 to this issue.


@rahgurung
Copy link

So, I'm planning to make a new Combined.js in the src and then build it as a separate new chart or you want me to re-use the Bar and Line code, is that possible in some way?

@timqian
Copy link
Owner

timqian commented Sep 5, 2019

@gurrrung Thanks for the interest, I think we should re-use the Bar and Line code in some way, so we won't need to copy-paste code around when the charts changes(e.g. #27), but the current implementation of them is not easy to be reused, we may need to refactor the code a little

Suggestions on the refactoring are welcomed

Ref: How chart.js implement mixed type chart https://www.chartjs.org/docs/latest/charts/mixed.html

@timqian timqian self-assigned this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants