Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options config required to plot the Line chart #42

Open
ajduke opened this issue Oct 9, 2019 · 4 comments
Open

options config required to plot the Line chart #42

ajduke opened this issue Oct 9, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@ajduke
Copy link
Contributor

ajduke commented Oct 9, 2019

Describe the bug
I was tinkering around this library and started the example from the README.md for Line chart and found that , its not plotting the graph without presence of the options config. Its plots the x and y axes but no lines inside those graph, look for screenshot 1 for more details

But If i do provide the options, even with empty object, it plots lines accordingly

Screenshot

Screenshot 1

image

How to reproduce
Look for the codepen link here

@ajduke ajduke added the bug Something isn't working label Oct 9, 2019
@ajduke ajduke changed the title options config required to plot the Line chart options config required to plot the Line chart Oct 9, 2019
@ajduke
Copy link
Contributor Author

ajduke commented Oct 9, 2019

As this is not a good experience for the starter developer for this library like me, I am planning to raise the PR for the to fix the README to fix this. I know, in the core of the library we will need to fix this

@timqian
Copy link
Owner

timqian commented Oct 10, 2019

@ajduke Thanks for pointing it out, we definitely need to fix this. I will merge your PR first and see if I can find a good way to handle this

@ajduke
Copy link
Contributor Author

ajduke commented Oct 13, 2019

@timqian I have raised #47 PR to fix this issue, i had already explained in PR why the issue was happening.
Let me know, if any changes needs to PR.

Also, this issue will exists in the other charts as well as above or if user is passing options.dataColors as empty array

@timqian
Copy link
Owner

timqian commented Nov 22, 2019

Fixed in this commit cef9ba2#diff-fbc43a77b4e8fe64398aa79145272a6bR33

and deployed to v1.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants