Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server instance (of @tinyhttp/app) hangs on test since 2.0.33 #410

Open
aldy505 opened this issue Oct 1, 2023 · 4 comments
Open

Server instance (of @tinyhttp/app) hangs on test since 2.0.33 #410

aldy505 opened this issue Oct 1, 2023 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed needs reproduction Needs a reproduction demo / repository to investigate further

Comments

@aldy505
Copy link
Member

aldy505 commented Oct 1, 2023

Describe the bug

Like usual, I was maintaining malibu, bumping the dependencies. I ran pnpm run test, and got it hanging on me. At first I thought it's a problem with uvu, yet uvu is not updated. Then I thought it's a problem with Typescript -- since I upgraded a major version from v4 to v5. When I downgraded just Typescript from v5 to v4 (v4.9.5 exactly), it.. still hangs. I also thought it's a problem with the Node version I was using (v20), downgraded to (v18) and it still hangs.

Then, I downgraded @tinyhttp/app back to 2.0.29 from 2.2.0, and the test got passed without even hanging. I trace the version one by one, and got the hanging problem since 2.0.33.

Saw the diff between 2.0.29 and 2.2.0, didn't think there's something that's causing the issue. See the diff here.

To Reproduce

See my PR on malibu here: tinyhttp/malibu#5

Expected behavior

It's not supposed to be hanging.

Versions

  • node: 18, 20
  • @tinyhttp/app: 2.0.33

Additional context

Add any other context about the problem here.

@aldy505 aldy505 added the bug Something isn't working label Oct 1, 2023
@talentlessguy talentlessguy added help wanted Extra attention is needed needs reproduction Needs a reproduction demo / repository to investigate further labels Oct 8, 2023
@talentlessguy
Copy link
Member

talentlessguy commented Oct 8, 2023

@aldy505 could you please write out a minimal reproduction for the hanging? (a code snippet)

@aldy505
Copy link
Member Author

aldy505 commented Oct 9, 2023

@aldy505 could you please write out a minimal reproduction for the hanging? (a code snippet)

Will do later this weekend (or the next 2 weekend)

@aarontravass
Copy link
Member

@aldy505 any updates?

@aldy505
Copy link
Member Author

aldy505 commented Dec 19, 2023

@aldy505 any updates?

@aarontravass not yet, I'm occupied with work until early January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed needs reproduction Needs a reproduction demo / repository to investigate further
Projects
None yet
Development

No branches or pull requests

3 participants