Tests TODO

[talentlessguy]

The final goal is of this issue is to achieve ~80-100% coverage

here's a todo list of things that require tests (based on the __tests__ folder):

⚠️ List is in progress, I'll be adding new test tasks over time, here are some that you can submit already

• core
  • app
    • app - app.set, app.enable, app.disable (codecov)
    • onError - Test a case where an error doesn't have an HTTP status code, neither is a string (codecov)
  • request
  • response
• modules
  • accepts
  • cookie-signature
  • cookie
  • etag (Write tests for etag #133)
  • req (Write tests for @tinyhttp/req #140)
  • res
    • res.format - if default only is specified, call it as a function (codecov)
    • res.format - if nothing is specified, throw 406 (codecov)
  • router
  • send (Write tests for @tinyhttp/send #143)
• wares
  • cookie-parser
  • cors
    • Accept a function to set origin
  • dotenv
  • favicon
  • jwt
    • Should work with different algorithms (codecov) [pending]
  • logger
  • ping
  • bot-detector (Write tests for bot-detector #111)
  • ip-filter
  • jsonp (Write tests for @tinyhttp/jsonp #123)\

If you want to help with tests, write down to this thread with your questions

[talentlessguy]

Thanks for improved coverage for accepts by @BRA1L0R via #97 and #99

[aneeshrelan]

Can I try adding tests for bot-detector?

[talentlessguy]

@aneeshrelan yup, will create a separate issue for that now

[talentlessguy]

@aneeshrelan check #111

[aneeshrelan]

@talentlessguy I see some tests for the mentioned wares, are they still needed?

[shubhi23994]

I can take up some tests

[talentlessguy]

@shubhi23994 which tests would you like to take up? I will create a separate issue for those you pick

[talentlessguy]

@aneeshrelan I receive lots of PRs during hacktoberfest so I could have missed some of them

and yes, tests are still needed

[shubhi23994]

I can pick up jsonp to start with

[talentlessguy]

@shubhi23994 alright, making a new issue then :D

[talentlessguy]

@shubhi23994 write in #123 so i can assign you

[MaurizioPz]

Hi, may I take pick ETag?

[talentlessguy]

@MaurizioPz yup, pls wait a sec imma setting up a new issue for this (to later assign it to you)

[talentlessguy]

@MaurizioPz check this: #133

[MaurizioPz]

Hi, may I take also req

[talentlessguy]

@MaurizioPz alright, making a new issue

[talentlessguy]

@MaurizioPz check #140 and write there pls so I can assign you

[alcar]

Hey, @talentlessguy! I'm not familiar with the codebase, but I'm happy to try writing some tests if you still need it!

[talentlessguy]

@alcar hi! you can pick any of the things to test, and I'll open a separate issue for you - e.g. if you decide to test @tinyhttp/session - I'll create an issue "Write tests for @tinyhttp/session"

pick the one you want and I'll assign you to those tests

[alcar]

Do you have any recommendations for a newcomer? If not, I can just pick up the first available one from the list!

[talentlessguy]

@alcar @tinyhttp/send is quite easy to test, so i'd pick that

but feel free to pick anything else

[alcar]

@talentlessguy Sounds great! Could you please create an issue and assign it to me then?

[talentlessguy]

@alcar yup currently making an issue for you

[talentlessguy]

@alcar here you go -> #143

[alcar]

@talentlessguy I'm happy to pick up a new one if you still need it!

[talentlessguy]

@alcar i will setup an issue for testing @tinyhttp/session for you tomorrow

[KoljaTM]

Would like to help out as well. Anything up for grabs?

[talentlessguy]

@alcar check this => #163

[talentlessguy]

@KoljaTM @tinyhttp/pug has 0% coverage so you can take it

or other modules with almost 100% coverage, such as @tinyhttp/cors

[KoljaTM]

ok, i'll see what i can do for the pug package

[MVelez94]

I'm interested in contributing tests. I think wares/favicon would be small enough and beginner friendly. How do I start?

[aldy505]

I'm interested in contributing tests. I think wares/favicon would be small enough and beginner friendly. How do I start?

@MVelez94 See https://github.com/tinyhttp/favicon

[Khotam]

hi @talentlessguy, i would like to contribute but have no experience with open source projects. could you give me some easier tasks?

[ismailmmd]

Hey @talentlessguy , I would like to help with wares/cookie-parser . Could you please create a subtask for the same?

[talentlessguy]

@ismailmmd no need to, just submit the PR and link to this issue (write like related to #92)

[talentlessguy]

@Khotam take a look at other tasks

[ismailmmd]

@talentlessguy I think the above list is not updated. I checked and saw favicon and cookie-parser repos have 💯 >99% coverage

[talentlessguy]

@ismailmmd cookie parser has an uncovered line with secret array I think, would you like to write a test for it? or just make sure it's covered

[ismailmmd]

@talentlessguy will give it a try 👍

[ismailmmd]

Created a PR for cookie-parser @talentlessguy 🙏 please review

[talentlessguy]

@ismailmmd merged!

[ismailmmd]

@talentlessguy Added one more PR to jwt

[pourdaavar]

Hi there.
how can I participate?

[talentlessguy]

@hoseinprd would be nice to cover this part of code on router: https://coveralls.io/builds/55425079/source?filename=packages%2Frouter%2Fsrc%2Findex.ts#L134

[pourdaavar]

ok bro