Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in the way browsers work with wasm causes issues with some js implementation to load the wasm. #175

Open
Jieiku opened this issue Sep 4, 2023 · 4 comments

Comments

@Jieiku
Copy link
Collaborator

Jieiku commented Sep 4, 2023

I am wrapping up a refactor on Abridge.

I needed to test that tinysearch still works, and I ran into an error I have not seen before:

2023-09-03_16-31-40

I then see its also an issue on endler.dev just click into the search box with the developer console open and you will see it:

2023-09-03_17-20-09

So I then tried the endler.dev demo file and it is working properly, so it seems the actual wasm is OK? but the way that we load it in JS is the problem?

I am not yet sure what to do to fix it. It seems its related to loading the wasm on demand, when a user clicks into the search box, ideally we want to keep the ability to do that.

@mre
Copy link
Member

mre commented Sep 4, 2023

Similar problem here: rustwasm/wasm-bindgen#2779

Thanks for reporting.

@mre
Copy link
Member

mre commented Sep 4, 2023

We should check with the latest wasm-pack version and double-check if we use release mode everywhere.

@Jieiku
Copy link
Collaborator Author

Jieiku commented Sep 4, 2023

I tested using tinysearch v7 as well. no difference. (that one definitely used to work) I don't have time to check anything else today, headed to work shortly.

@mre
Copy link
Member

mre commented Sep 4, 2023

Appreciate the feedback. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants