Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] After moving to v36.0.10 action is not able to locatecommit #1204

Closed
3 tasks done
krukowskid opened this issue May 31, 2023 · 6 comments · Fixed by #1205
Closed
3 tasks done

[BUG] After moving to v36.0.10 action is not able to locatecommit #1204

krukowskid opened this issue May 31, 2023 · 6 comments · Fixed by #1205
Labels
bug Something isn't working

Comments

@krukowskid
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

36.0.10 breaks the action for me.
After update the action is unable to locate the commit sha

To Reproduce

use below steps with tj-actions/changed-files set to v36 or v36.0.10

      - name: Get repository
        uses: actions/checkout@v3
        with:
          ref: ${{ github.event.pull_request.head.sha }}

      - name: Get all changed files
        id: changed-other-files
        uses: tj-actions/changed-files@v36.0.10
        with:
          files_ignore: ${{ inputs.ignore_changed }}

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

action should resolve changed files

Relevant log output

Warning: fatal: Invalid symmetric difference expression 9a6f6be724b80792a13e151181349242b6714efe...05707e12b7f957f4b00d92c3898d31a72a1cec9d
  
Warning: fatal: Invalid symmetric difference expression 9a6f6be724b80792a13e151181349242b6714efe...05707e12b7f957f4b00d92c[38]
 
Error: Unable to locate the commit sha: 9a6f6be724b80792a13e151181349242b6714efe
Error: Please verify that the commit sha is correct, and increase the 'fetch_depth' input if needed
Warning: fatal: Invalid revision range 9a6f6be724b80792a13e1511813492[42]
 
Error: Unable to determine a difference between 9a6f6be724b80792a13e151181349242b6714efe..05707e12b7f957f4b00d92c3898d31a72a1cec9d

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@krukowskid krukowskid added the bug Something isn't working label May 31, 2023
@github-actions
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@jackton1
Copy link
Member

@krukowskid Seems odd but I'm unable to replicate this issue with the test I ran here and result here

@jackton1
Copy link
Member

Can you create a public project with minimal code that replicates this issue ?

In the meantime, I'll close this for now pending your feedback.

@krukowskid
Copy link
Author

@jackton1 I am unable to replicate this issue too... tested both v36.0.10 and v36.0.11. Reverted my workflow to use major version - v36. Maybe it was just temporary GitHub problem. Anyway thank you for super fast reaction!

@jackton1
Copy link
Member

jackton1 commented Jun 2, 2023

@krukowskid I was able to replicate this issue by force-pushing changes to an existing PR branch. It should be fixed now.

@Spongman
Copy link

Spongman commented Jun 12, 2023

this is still an issue for me in the latest release (v36.1.0):

Warning: Input 'dir_names_exclude_root' has been deprecated with message: Use `dir_names_exclude_current_dir` instead.
Run tj-actions/changed-files@v36.1.0
changed-files
  Running on a pull_request event...
  Error: Unable to locate the commit sha: 
  Error: Please verify that the commit sha is correct, and increase the 'fetch_depth' input if needed
  Retrieving changes between fd6837197d983ea41ae505f13d0a[2](https://github.com/Spongman/ts-rust-zig-deez/actions/runs/5247248978/jobs/9477157404?pr=8#step:3:2)9bad83c45ad (foo) → a68182f88835d8c[34](https://github.com/Spongman/ts-rust-zig-deez/actions/runs/5247248978/jobs/9477157404?pr=8#step:3:35)d9a3dcd9a51fa09fe702144 (foo)
  All Done!

https://github.com/Spongman/ts-rust-zig-deez/actions/runs/5247248978/jobs/9477157404?pr=8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants