Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Get version of files before they were edited #2089

Closed
2 tasks done
justanotheranonymoususer opened this issue May 13, 2024 · 4 comments
Closed
2 tasks done
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@justanotheranonymoususer

Is this feature missing in the latest version?

  • I'm using the latest release

Is your feature request related to a problem? Please describe.

I need a CI that makes sure a change is correct, so if a file was edited, i need the old ver. There is already recover_deleted_files, but I need something like recover_modified_files. The feature is the same, just need not limit it to deleted.

Describe the solution you'd like?

recover_modified_files?

Describe alternatives you've considered?

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@justanotheranonymoususer justanotheranonymoususer added the enhancement New feature or request label May 13, 2024
@tj-actions-bot
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@jackton1
Copy link
Member

Hi @justanotheranonymoususer this seems like one off use case for now I’ll suggest utilizing a script that you can use to recover modified files.

We can revisit this in the future if it does become a general problem.

@jackton1 jackton1 closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
@justanotheranonymoususer
Copy link
Author

Isn't recover_deleted_files also a one-off problem then?
Basically I don't agree, I think it has many use cases, and it's a bummer to write a non-trivial script (with fetch and whatnot) for something you guys already worked on to implement correctly, all's needed is to not limit it to deleted files.

@justanotheranonymoususer
Copy link
Author

Basically all that's needed is to control this:

deletedFiles: allDiffFiles[ChangeTypeEnum.Deleted],

To be able to also pass 'M'

@tj-actions tj-actions locked as too heated and limited conversation to collaborators May 13, 2024
@jackton1 jackton1 added the wontfix This will not be worked on label May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants