Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify readme code examples with 'const' #1026

Merged
merged 1 commit into from Aug 23, 2019

Conversation

abetomo
Copy link
Collaborator

@abetomo abetomo commented Aug 23, 2019

Problem

'var' and 'const' are mixed in Readme code example.

Solution

  • It is better to be unified.
  • Recently, 'const' is often used.

ChangeLog

@shadowspawn shadowspawn requested review from shadowspawn and removed request for shadowspawn August 23, 2019 01:53
* It is better to be unified.
* Recently, 'const' is often used.
@abetomo abetomo force-pushed the unify_readme_code_examples_with_const branch from 6de7de6 to e9c24fe Compare August 23, 2019 01:54
@shadowspawn
Copy link
Collaborator

shadowspawn commented Aug 23, 2019

Oops, either my web page was out of date or I was not paying attention. Was intending to add myself to review (soon) but was already requested. :-)

Thanks @abetomo I will review soon.

@shadowspawn
Copy link
Collaborator

On a slightly related note (const), three structure things I am thinking of for v4:

  • only officially support LTS versions of node that we test with CI (but not deliberately break recent versions)
  • switch testing framework
  • add Windows CI testing

@abetomo
Copy link
Collaborator Author

abetomo commented Aug 23, 2019

For testing on Windows, you can use GitHub Actions.

Example #1027

Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abetomo 👍

@abetomo
Copy link
Collaborator Author

abetomo commented Aug 23, 2019

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants