Display help despite missing required option #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks @abetomo. I'll prepare a PR for a patch release. |
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This was referenced Nov 19, 2019
This was referenced Mar 6, 2020
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #1089 #1092
Problem
When ask for help but there is a missing required option, getting error instead of help, so can't find out more.
e.g.
Solution
Check for missing required options after checking for displaying help. This fix covers help for commands with action handlers, and help on the main program.
(It does not cover program with a required option and calling help on an executable subcommand, which seems an unlikely case. Deal with it if and when it comes up.)