New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/command.executableSubcommand.lookup.test.js consistently timing out #1123
Comments
Thanks for including Commander! We saw a timeout issue and increased the timeout on the develop branch, but has not been merged onto master yet: #1108 I'll merge it across soon instead of waiting for the next release. Not sure why the test is taking so long and a fallback is just removing that one particular test! |
Timeout increased. Let us know if still causing (false positive) problems. |
Thank you very much for the fast response! |
|
Oh, testing against latest release rather than master branch? Foiled. FYI: next release is likely to be early January: #1102 (comment) |
Reworked test in #1125, not released yet. |
@BridgeAR Commander v4.1 released. |
Awesome, thank you very much! |
We check
commander
for failures on citgm to verify that new Node.js releases do not break anything. Recent changes to commander or to the test suite made one test consistently fail on our infrastructure with a timeout.It would be great to either increase the maximum time allowed for that test to at least 10 seconds or (better) to split the test into multiple ones to reduce the individual run time, if possible.
Refs: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2134/nodes=ubuntu1604-64/testReport/junit/(root)/citgm/commander_v4_0_1/
(Available for ~7 days)
The text was updated successfully, but these errors were encountered: