Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/command.executableSubcommand.lookup.test.js consistently timing out #1123

Closed
BridgeAR opened this issue Dec 17, 2019 · 8 comments
Closed

Comments

@BridgeAR
Copy link

BridgeAR commented Dec 17, 2019

We check commander for failures on citgm to verify that new Node.js releases do not break anything. Recent changes to commander or to the test suite made one test consistently fail on our infrastructure with a timeout.

It would be great to either increase the maximum time allowed for that test to at least 10 seconds or (better) to split the test into multiple ones to reduce the individual run time, if possible.

Refs: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2134/nodes=ubuntu1604-64/testReport/junit/(root)/citgm/commander_v4_0_1/
(Available for ~7 days)

@shadowspawn
Copy link
Collaborator

shadowspawn commented Dec 17, 2019

Thanks for including Commander! We saw a timeout issue and increased the timeout on the develop branch, but has not been merged onto master yet: #1108

I'll merge it across soon instead of waiting for the next release.

Not sure why the test is taking so long and a fallback is just removing that one particular test!

@shadowspawn
Copy link
Collaborator

shadowspawn commented Dec 17, 2019

Timeout increased. Let us know if still causing (false positive) problems.

@BridgeAR
Copy link
Author

Thank you very much for the fast response!

@BridgeAR
Copy link
Author

BridgeAR commented Dec 17, 2019

I am going to close this as resolved.
Let's keep it open until the next release is published.

@BridgeAR BridgeAR reopened this Dec 17, 2019
@shadowspawn
Copy link
Collaborator

Oh, testing against latest release rather than master branch? Foiled.

FYI: next release is likely to be early January: #1102 (comment)

@shadowspawn
Copy link
Collaborator

Reworked test in #1125, not released yet.

@shadowspawn
Copy link
Collaborator

@BridgeAR
Removed direct use of ts-node in the problem tests and have not seen any timeouts since the change.

Commander v4.1 released.

@BridgeAR
Copy link
Author

BridgeAR commented Jan 6, 2020

Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants