Typing: In @types/node v13, NodeJS.EventEmitter is no longer a class

[be5invis]

Source: DefinitelyTyped/DefinitelyTyped#40927

• BREAKING: Replaced global EventEmitter class with interface as it's purely virtual and only there for global declarations.
  • This required various updates in other package since they sometimes used extends EventEmitter or extends NodeJS.EventEmitter.

[shadowspawn]

Thanks for report.

Independently, I recently wrote a PR to remove the EventEmitter from our TypeScript to try in Commander 5.x but was not planning for that in 4.x: #1146

I'm not sure what we'll do for 4.x. That PR for DefinitelyTyped is across a LOT of files so that fix is widely applied and will look into that.

[shadowspawn]

I think Commander may not not affected by this change, as Command is declared as an interface not a class:

commander.js/typings/index.d.ts

Line 28 in f31d757

interface Command extends NodeJS.EventEmitter {

I tried updating to latest @types/node@13 and was not able to reproduce any problems. Are you seeing issues?

[be5invis]

@shadowspawn
I tried to update Commander and it seems working now. Maybe I was using old version that caused this? Closed.

[shadowspawn]

Old version... Digging... #1081

For future readers, this issue is fixed in Commander v4.