Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document links to errors #1306

Merged
merged 1 commit into from Jul 23, 2020

Conversation

abetomo
Copy link
Collaborator

@abetomo abetomo commented Jul 19, 2020

Pull Request

Problem

Not that there was a problem.

Solution

I saw another tool that included the URL of the document in the error message.
That helped to solve the problem.

It's just one idea, so close it if you don't need it.

ChangeLog

A link would also be helpful in resolving the error.

link is to:
https://github.com/tj/commander.js#avoiding-option-name-clashes
@shadowspawn
Copy link
Collaborator

Short version: 👍


Long version

The small concern I have is building a link to a particular section in the README is fragile in the longterm because the README may change. It doesn't completely break though, just loads at top of page.

We are trying hard in the throw to help the person solve the problem, and adding an URL may help them.

(If we need to offer more specific help for a throw case we could add a separate page to link to, but hopefully we are offering enough!)

@shadowspawn
Copy link
Collaborator

I'll try it out before I finish reviewing it. Because the message appears in the middle of a throw with stack etc, I had tried to pull together the additional lines so they didn't get lost in the noise starting the lines with dash. Not sure how effective it is, so I'll try generating a throw with new link to see how it looks!

@abetomo abetomo changed the base branch from master to develop July 22, 2020 23:05
@abetomo
Copy link
Collaborator Author

abetomo commented Jul 23, 2020

Thank you for the review!

@abetomo abetomo merged commit 8fb669f into tj:develop Jul 23, 2020
@abetomo abetomo deleted the feature/add_document_links_to_errors branch July 23, 2020 21:22
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 25, 2020
@shadowspawn shadowspawn added this to the v6.1.0 milestone Aug 25, 2020
@shadowspawn
Copy link
Collaborator

Released in Commander v6.1
https://github.com/tj/commander.js/releases/tag/v6.1.0

@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants