Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve basedir calculation to fix #1274 #1322

Merged
merged 2 commits into from Aug 1, 2020

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

With some of the new ways of creating subcommands, the script path from the command line may not have been set on the Command when calling executable subcommand. Although not a common situation

See #1274

Solution

Use the same fallback as when script path not know during command creation.

ChangeLog

  • fix executable subcommand launching when script path not known

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadowspawn shadowspawn merged commit a71d592 into tj:develop Aug 1, 2020
@shadowspawn shadowspawn deleted the feature/improve-exec-basedir branch August 1, 2020 22:36
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 1, 2020
@shadowspawn shadowspawn added this to the v6.1.0 milestone Aug 5, 2020
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Aug 28, 2020
@shadowspawn
Copy link
Collaborator Author

Released in Commander v6.1
https://github.com/tj/commander.js/releases/tag/v6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants