Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow partial argument descriptions #1323

Merged
merged 1 commit into from Aug 1, 2020
Merged

Allow partial argument descriptions #1323

merged 1 commit into from Aug 1, 2020

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

If any argument descriptions are provided to .arguments(), then all the arguments must be described or there is a runtime error.

Solution

Fallback to empty argument description if missing.

See #1321

ChangeLog

  • allow just some arguments in argumentDescription to .description()

abetomo
abetomo approved these changes Aug 1, 2020
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 1, 2020
@shadowspawn shadowspawn merged commit c7f5f78 into tj:develop Aug 1, 2020
@shadowspawn shadowspawn deleted the feature/allow-partial-argument-descriptions branch August 1, 2020 22:38
@shadowspawn shadowspawn added this to the v6.1.0 milestone Aug 5, 2020
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Aug 28, 2020
@shadowspawn
Copy link
Collaborator Author

Released in Commander v6.1
https://github.com/tj/commander.js/releases/tag/v6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadowspawn @abetomo