Add combineFlagAndOptionalValue #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
|
Released in Commander v6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Previous versions of Commander always expanded combined short flags, so
-fbalways expanded to-f -b. This allowed combining short flags for options with optional values as though they were boolean flags.The new behaviour is that an option with an optional value and the value can be combined, so
-fbeffectively expands to-f b.This is a breaking change for old programs which heavily use optional values without an easy fix.
See: #1203
Solution
Allow choosing between the two behaviours. Not included in the README. (Thinking might instead include in an future extended discussion of issues with optional values, see #1315.)
ChangeLog
.combineFlagAndOptionalValue(false)to ease upgrade path from older versions of Commander (Add combineFlagAndOptionalValue #1326)