Allow tsx file extension for sub-commands (#1367) #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How are you running your program so that I know how this works with |
|
@shadowspawn yep is essentially the same thing... and i'm using exactly that command to run it here with tsx files :) |
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
|
Released in Commander v6.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
I'm using ink to implement my cli-app which uses React and right now commander does not look for sub-command files in tsx extension. This PR add tsx as a valid file extension when looking for sub-command files.
Related Issue: #1367
Solution
It's a very simple PR where i just added tsx as valid file extension in
_executeSubCommandfunction.ChangeLog