Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chinese README for 7.0 #1420

Closed
shadowspawn opened this issue Dec 20, 2020 · 7 comments
Closed

Update Chinese README for 7.0 #1420

shadowspawn opened this issue Dec 20, 2020 · 7 comments
Milestone
v7.0.0

Comments

@shadowspawn
Copy link
Collaborator

A PR to update the Chinese version of README is welcome.

README commits on release/7.x:
https://github.com/tj/commander.js/commits/release/7.x/Readme.md

Compare between master and release/7.x:
master...release/7.x

Quite a few changes to the README with some rearrangements, some additions, and catching up with latest code patterns.

There is some new additional documentation in the docs folder, but I think those files are less important than the README:
https://github.com/tj/commander.js/tree/release/7.x/docs
@shadowspawn shadowspawn added this to the v7.0.0 milestone Dec 20, 2020
@y1hao
Copy link
Contributor

y1hao commented Jan 7, 2021

I can do both updating and translate docs folder = )

@shadowspawn
Copy link
Collaborator Author

shadowspawn commented Jan 7, 2021 •
edited

Thanks @CoderYihaoWang

@shadowspawn
Copy link
Collaborator Author

A small heads-up, I am planning to change a few sentences in the README as part of #1429 soon.

@y1hao
Copy link
Contributor

y1hao commented Jan 7, 2021

Got it. Then I will send the PR after the #1429 one gets merged, to reflect the changes in the translation.

@shadowspawn
Copy link
Collaborator Author

Merged #1429

@y1hao y1hao mentioned this issue Jan 8, 2021
Merged
@y1hao
Copy link
Contributor

y1hao commented Jan 8, 2021

I have completed the translation and submitted PR = )

shadowspawn pushed a commit that referenced this issue Jan 8, 2021
@y1hao
Feature/update chinese readme (#1431)
ff301fa 
* Update Chinese README to match release/7.x (#1420)

* Add Chinese versions of documents in the docs folder; update links in README (#1420)

* Update Chinese README: excess args error opt-in (#1420) (#1429)
@shadowspawn shadowspawn added pending release Merged into a branch for a future release, but not released yet and removed help wanted pending release Merged into a branch for a future release, but not released yet labels Jan 8, 2021
@shadowspawn
Copy link
Collaborator Author

Included in Commander 7.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0.0
Development

No branches or pull requests
2 participants
@shadowspawn @y1hao