Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cjs to list of expected node script extensions #1449

Merged
merged 3 commits into from Jan 30, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jan 30, 2021

Pull Request

Problem

Node uses .cjs for specifically CommonJS javascript files, like .mjs for esm. Commander does not check for that extension when considering how to launch external stand-alone subcommands.

Solution

Add .cjs.

ChangeLog

  • Add .cjs to expected script file extensions.

To Do

  • Add tests for file suffixes. We have a test for .ts but not for .mjs or .cjs.

@shadowspawn shadowspawn changed the title Add cjs to list of expected node script extensions [WIP] Add cjs to list of expected node script extensions Jan 30, 2021
@shadowspawn shadowspawn changed the title [WIP] Add cjs to list of expected node script extensions Add cjs to list of expected node script extensions Jan 30, 2021
@shadowspawn shadowspawn marked this pull request as ready for review January 30, 2021 04:57
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants