Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unknown options check if there is a better error to display #1464

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Feb 5, 2021

Pull Request

I think this is working our sensibly. Making changes in a complicated piece of the code so going slowly.

Problem

In Commander v5 we started checking for unknown options in more situations, which was an improvement in many cases. However, it unintentional blocked some "better" errors such as an unknown command, and blocked suggestions for the unknown commands (listener for command:*).

Related issue: #1460

Solution

Work through cases and don't block a better error by checking for unknown options. Especially, when the issue is likely to be a misspelled command.

ChangeLog

@shadowspawn shadowspawn changed the title WIP: Skip unknown options check if there is a better error to display Skip unknown options check if there is a better error to display Feb 5, 2021
@shadowspawn shadowspawn marked this pull request as ready for review February 5, 2021 10:06
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shadowspawn shadowspawn merged commit 4f78587 into tj:develop Feb 5, 2021
@shadowspawn shadowspawn deleted the feature/unknown-command-before-unknown-option branch February 5, 2021 19:55
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Feb 5, 2021
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants