Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributeName to Option typings #1483

Merged
merged 1 commit into from Mar 8, 2021
Merged

Add attributeName to Option typings #1483

merged 1 commit into from Mar 8, 2021

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

.attributeName() in JavaScript but not TypeScript.

Related: #1480

Solution

Added to typings.

ChangeLog

  • Added .attributeName() to TypeScript typings for Option

abetomo
abetomo approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Mar 8, 2021
@shadowspawn shadowspawn merged commit d3a9e7a into tj:develop Mar 8, 2021
@shadowspawn shadowspawn deleted the feature/attribute-name-typing branch March 20, 2021 05:36
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadowspawn @abetomo