Add getOptionValueSourceWithGlobals #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abetomo
reviewed
Dec 19, 2022
|
|
||
| getOptionValueSourceWithGlobals(key) { | ||
| // global overwrites local, like optsWithGlobals | ||
| let source; |
There was a problem hiding this comment.
For reference :
You can also write the following using findLast.
return getCommandAndParents(this)
.findLast((cmd) => cmd.getOptionValueSource(key) !== undefined)
.getOptionValueSource(key);There was a problem hiding this comment.
You can use Node.js 18 or later.
My apologies.
There was a problem hiding this comment.
I started out planning to target Commander v10.x just so I could use ??, but switched to old-school Node 12 compatible code for now. Eventually!
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
|
Released with Commander v9.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
We added
.optWithGlobals()to make working with globals easier. And.getOptionValueSource()for more complex programs. But how do you get the option value source including globals?See #1713
Solution
Added
.getOptionValueSourceWithGlobals().Sticking with the obvious and long name for what is probably a seldom used routine. Not planning to add to README.
ChangeLog
.getOptionValueSourceWithGlobals()