Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowUnknownOption missing in .copyInheritedSettings()? #1944

Closed
aweebit opened this issue Aug 5, 2023 · 1 comment
Closed

allowUnknownOption missing in .copyInheritedSettings()? #1944

aweebit opened this issue Aug 5, 2023 · 1 comment

Comments

@aweebit
Copy link
Contributor

aweebit commented Aug 5, 2023

#1557 shows that the allowUnknownOption setting was already available at the time when .copyInheritedSettings() was introduced. Is there a particular reason why it was not included in the inherited settings unlike the very similar allowExcessArguments, or was it simply forgotten? If so, should it be added?

@shadowspawn
Copy link
Collaborator

This is as intended. I think allowUnknownOption is more likely to apply to particular commands than all commands. So somewhat like .passThroughOptions(), for special cases.

(I don't consider allowUnknownOption a first-class feature. It is a bit of a simple historical "hack" that just turns off the error handling. Hopefully it does help in some hybrid parsing scenarios!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants