Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customFds option for child_process.spawn is deprecated #586

Closed
ghost opened this issue Nov 12, 2016 · 4 comments
Closed

customFds option for child_process.spawn is deprecated #586

ghost opened this issue Nov 12, 2016 · 4 comments
Milestone
v4.0.0

Comments

@ghost
Copy link

ghost commented Nov 12, 2016 •
edited by ghost

customFds option for child_process.spawn is deprecated since nodejs/node@2454695.
Use stdio instead.

See https://github.com/nodejs/node/wiki/API-changes-between-v0.10-and-v4
@shadowspawn
Copy link
Collaborator

We are passing stdio too so I suspect were deliberately working with old and new version of node.

https://github.com/nodejs/node/blob/master/doc/api/deprecations.md#dep0006-child_process-optionscustomfds

Assuming minimum version of node is now at least 4, can probably just delete customFds.

@shadowspawn shadowspawn added this to the v4.0.0 milestone Sep 14, 2019
@shadowspawn shadowspawn mentioned this issue Sep 21, 2019
Merged
@shadowspawn
Copy link
Collaborator

Removed customFds on the develop branch for the next release (#1052).

@shadowspawn
Copy link
Collaborator

v4.0.0-0 prerelease published: #1067

@shadowspawn
Copy link
Collaborator

v4.0.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@shadowspawn