#395 fix, short options do not understand adjacent values

[TheRoSS]

Example of the bug:

commander.option("-c ")
console.log("C:", commander.C)

$ node program -c234
C: -2

[shadowspawn]

It looks like this pull request works with -a234 => a=234 for an option taking a value, and -xyz => -x -y -z if x is a boolean flag, but leaves some combination cases like -axz 3 or -xa234.

It would be nice if there was a standard we could refer to for short flag handling. Should we only consider numbers?

Keeping pull request open for now.

[shadowspawn]

Link to issue: #395

[shadowspawn]

Found a couple of posix references which align with suggested pull request, and python adds the last short flag taking a value.

1. https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html

Multiple options may follow a hyphen delimiter in a single token if the options do not take arguments. Thus, ‘-abc’ is equivalent to ‘-a -b -c’.

2. https://www.gnu.org/software/libc/manual/html_node/Example-of-Getopt.html#Example-of-Getopt

% testopt -a -b
aflag = 1, bflag = 1, cvalue = (null)

% testopt -ab
aflag = 1, bflag = 1, cvalue = (null)

% testopt -c foo
aflag = 0, bflag = 0, cvalue = foo

% testopt -cfoo
aflag = 0, bflag = 0, cvalue = foo

3. https://docs.python.org/2/library/argparse.html#option-value-syntax

For short options (options only one character long), the option and its value can be concatenated

Several short options can be joined together, using only a single - prefix, as long as only the last option (or none of them) requires a value

[shadowspawn]

Are you still interested in doing more work on this @TheRoSS ?

I am now happy with supporting adjacent values. I have a few small changes I would like made, and want to do some testing. Checking whether you are still engaged before I go further.

No problem if you are no longer interested, I'll find somewhere to reference this work for future use by someone else.

Thank you for your contributions.

[TheRoSS]

Good day. I am rather busy just now. But can participate in this issue in the end of May

[shadowspawn]

Wish I had noted the changes when I first reviewed, but only one that stood out when I looked again was to follow the existing whitespace format (odd though it is!).

[shadowspawn]

Merging into release/v3.0.0 branch

[shadowspawn]

(I deleted some requested style changes that turned out to be stale, format on master had changed.)

[shadowspawn]

I made some minor changes, and already had one approval. Merged into v3 and will be included in that release. Closing to make it clear that should not be merged into master.

Thank you for your contributions.

[shadowspawn]

Update: I am working my way through the parsing process looking into another bug. I suspect this fix only works for action based commands.

[shadowspawn]

Available now as a prerelease. See #1001

[shadowspawn]

Shipped in v3: https://github.com/tj/commander.js/releases/tag/v3.0.0