allow "-" hyphen as an option argument with subcommand #697
Conversation
| , should = require('should'); | ||
|
|
||
| program | ||
| .command('subcommand') |
There was a problem hiding this comment.
Could you please set the indent width to 2?
There was a problem hiding this comment.
@abetomo I fixed it. Thank you for your review!
|
Thank you PR! |
|
I have got as far as reproducing the problem. I have not confirmed the fix yet. |
There was a problem hiding this comment.
I reviewed and tested code and happy. Thanks for adding test too.
There are two issues, both introduced by changes made since Pull Request submitted:
- The test for index being valid has changed on master:
if ((i + 1) < argv.length && argv[i + 1][0] !== '-') {
- There are a number of style changes enforced by eslint (
npm run lint)
Are you still interested in making these changes @miyajan or should we make them ourselves?
|
Merging into |
shadowspawn
added
the
pending release
|
I made some minor changes as per my comments, and already had one approval. Merged into v3 and will be included in that release. Closing to make it clear that should not be merged into master. Thank you for your contributions. |
|
Available now as a prerelease. See #1001 |
|
Shipped in v3: https://github.com/tj/commander.js/releases/tag/v3.0.0 |
shadowspawn
removed
the
pending release
One character "-" hyphen is not accepted as an option argument with subcommand.
e.x. node test subcommand -a - --bravo - --charlie=-
Main command allowed "-" as an option argument in #139 . This patch will allow it also with subcommand.