fixes tests #794
Merged
fixes tests #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abetomo
approved these changes
May 1, 2018
index.js
Outdated
| this.required = ~flags.indexOf('<'); | ||
| this.optional = ~flags.indexOf('['); | ||
| this.required = flags.indexOf('<') >= 0; | ||
| this.optional = flags.indexOf('[') >= 0; | ||
| this.bool = !~flags.indexOf('-no-'); |
There was a problem hiding this comment.
Can you also convert this line as you did with previous one?
There was a problem hiding this comment.
I can do it if you want, but it will only be for readability/consistency, as the result is boolean as-is.
There was a problem hiding this comment.
Yes, for consistency purpose.
There was a problem hiding this comment.
No problem, it's done. :)
- Many tests were not properly invoking assertion functions. Now they are. - Fixed one test then was then failing because of side-effects from previous test setups. - Made small changes in some setups to avoid potential false negatives. (Also: made a tiny unrelated code change to ensure Options always has boolean properties; does not change any behavior, but may help with debugging.)
usmonster
force-pushed
the
fix-all-the-tests
branch
from
ca81722
to
679f897
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous test setups.
(Also: made a tiny unrelated code change to ensure Options always has
boolean properties; does not change any behavior, but may help with
debugging.)