Make 'npm test' run on Windows #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| readdirSync(__dirname).forEach((file) => { | ||
| if (!file.startsWith('test.') || extname(file) !== '.js') | ||
| return; | ||
| process.stdout.write(`\x1b[90m ${file}\x1b[0m `); |
There was a problem hiding this comment.
Does Windows support ANSI colors in terminal?
There was a problem hiding this comment.
Since Win10 terminal control sequences are supported natively by the console. For previous Windows versions Node (libuv to be more precise) has special emulation layer that translates the codes to winapi calls.
There was a problem hiding this comment.
Ok then! Thank you!
abetomo
added a commit
to abetomo/commander.js
that referenced
this pull request
Jun 28, 2018
It becomes unnecessary in the following PR * Make 'npm test' run on Windows tj#820
abetomo
added a commit
to abetomo/commander.js
that referenced
this pull request
Jun 28, 2018
It becomes unnecessary in the following PR * Make 'npm test' run on Windows tj#820
roman-vanesyan
pushed a commit
that referenced
this pull request
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Node to run the tests. Running
make testwill still work.