Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize help output #853

Merged
merged 6 commits into from Aug 31, 2018
Merged

Standardize help output #853

merged 6 commits into from Aug 31, 2018

Conversation

jaredpetersen
Copy link
Contributor

Cleans up the help output by:

  • removing the newline before and after
  • un-indenting commands and options

Fixes #852 and relates to #832.

index.js Outdated Show resolved Hide resolved
@jaredpetersen
Copy link
Contributor Author

@vanesyan Updated PR with your suggested changes. Good catch 👍

@roman-vanesyan roman-vanesyan merged commit 713db77 into tj:master Aug 31, 2018
@jaredpetersen
Copy link
Contributor Author

@vanesyan When will this be released?

@jaredpetersen
Copy link
Contributor Author

@vanesyan gentle bump

@abetomo
Copy link
Collaborator

abetomo commented Sep 7, 2018

We released 2.18.0.

@jaredpetersen
Copy link
Contributor Author

Thanks!

@mojavelinux
Copy link
Contributor

Another thing I've noticed is that commander.js adds a blank line after the category (such as options and commands). Most commands I use don't include this extra line.

commander.js:

Options:

  -v, --version                  output the version number

other commands

Options:
  -v, --version                  output the version number

Separate issue?

@jaredpetersen
Copy link
Contributor Author

@mojavelinux I think a separate issue would be good.

@jaredpetersen
Copy link
Contributor Author

@mojavelinux Just created one: #863.

@mojavelinux
Copy link
Contributor

Thanks a lot for taking care of that, @jaredpetersen. Much appreciated!

@ctjlewis

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize help output
5 participants