Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage: Problems with negating boolean options #939

Closed
shadowspawn opened this issue Mar 27, 2019 · 3 comments
Closed

Triage: Problems with negating boolean options #939

shadowspawn opened this issue Mar 27, 2019 · 3 comments

Comments

@shadowspawn
Copy link
Collaborator

shadowspawn commented Mar 27, 2019

People have a variety of problems with boolean options and negating. Opened this issue to collect the related issues found during triage.

NB: there is an open pull request and I have not yet looked at how well it addresses the issues, but likely to be some documentation work even if functionally solid.

Issues:

Pull Requests:

@shadowspawn shadowspawn changed the title Problems with negating boolean options Triage: Problems with negating boolean options Mar 30, 2019
@usmonster
Copy link
Contributor

Thanks for the triage work here, especially concerning the readme & examples updates in #953! FYI, I've updated my open PR (#795) to include your changes.

Regarding this:

NB: there is an open pull request and I have not yet looked at how well it addresses the issues, but likely to be some documentation work even if functionally solid.

Once you get around to finishing your review, please let me know if there's anything related to my comment on Custom Events that you think might require further functional or documentation updates. Thanks again!

@shadowspawn
Copy link
Collaborator Author

This issue will be resolved when v3.0.0 is released. Available now as a prerelease. See #1001

@shadowspawn
Copy link
Collaborator Author

Support for combined --foo and --no-foo has shipped in v3 (thanks @usmonster): https://github.com/tj/commander.js/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants