Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option that allows checking installation #74

Open
plroebuck opened this issue Apr 27, 2018 · 2 comments
Open

Add option that allows checking installation #74

plroebuck opened this issue Apr 27, 2018 · 2 comments

Comments

@plroebuck
Copy link

plroebuck commented Apr 27, 2018

Existing setupCmd somewhat determines what command/binary would be used on specific platforms.

Later, it throws an error for unsupported platforms, if no cmd is assigned.

Augment this with some method that would allow determining if that binary is actually installed on supported platform to allow runtime checking prior to usage. If not, throw error with "growl support available but not installed" and reference the appropriate platform-specific portion of your installation instructions (e.g., https://github.com/tj/node-growl/blob/master/Readme.md#mac-os-x-darwin for macOS).

@plroebuck
Copy link
Author

plroebuck commented Oct 15, 2018

ping @deiga @jbnicolai

@deiga
Copy link
Collaborator

deiga commented Nov 4, 2018

@plroebuck That sounds reasonable, feel free to make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants