Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README for macOS installation #75

Open
plroebuck opened this issue Apr 27, 2018 · 4 comments
Open

Update README for macOS installation #75

plroebuck opened this issue Apr 27, 2018 · 4 comments

Comments

@plroebuck
Copy link

Never could get growlnotify to work on macOS High Sierra.

Swap order in README to make growlnotify the secondary option to enable package support; at least terminal-notifier is actively maintained...
plroebuck added a commit to plroebuck/node-growl that referenced this issue Apr 30, 2018
@plroebuck
docs(README.md): Update Documentation
5e44104 
Rewrote much of the installation instructions. Expanded upon `growl()` arguments, adding msg and
callback sections, and correcting aspects of options. Added an example that plays sound. Minor cross
reference section modifications.

Fixes: tj#75
@plroebuck
Copy link
Author

plroebuck commented Oct 15, 2018 •
edited

ping @deiga

@deiga
Copy link
Collaborator

deiga commented Nov 4, 2018

@plroebuck please make a PR

@plroebuck
Copy link
Author

Six months to get a reply to do it myself... which I already had.

@deiga
Copy link
Collaborator

deiga commented Nov 4, 2018

@plroebuck Sure, you made it yourself, but I'm asking if you could make a PR about it.

And I'm sorry, my time is limited and I chose not to prioritise this over something else, so it took a while longer to react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deiga @plroebuck