From 54ac09fa3605d9875f2c732d18616dda475b05ea Mon Sep 17 00:00:00 2001 From: Tanguy Krotoff Date: Wed, 27 Jan 2021 21:12:51 +0100 Subject: [PATCH] Document whatwg-fetch Response.statusText bug https://github.com/github/fetch/pull/897 --- src/createHttpError.test.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/createHttpError.test.ts b/src/createHttpError.test.ts index 5ce98ab..6a1cec1 100644 --- a/src/createHttpError.test.ts +++ b/src/createHttpError.test.ts @@ -7,6 +7,9 @@ import { isWhatwgFetch } from './isWhatwgFetch'; const redirected = isWhatwgFetch ? undefined : false; const type = isWhatwgFetch ? 'default' : undefined; +// FIXME https://github.com/github/fetch/pull/897 +const emptyStatusText = isWhatwgFetch ? undefined : ''; + // "new Response()" gives a 200 response: // { // body: null @@ -244,7 +247,7 @@ test('no statusText', async () => { expect(response.ok).toEqual(true); expect(response.redirected).toEqual(redirected); expect(response.status).toEqual(200); - expect(response.statusText).toEqual(isWhatwgFetch ? undefined : ''); + expect(response.statusText).toEqual(emptyStatusText); expect(response.type).toEqual(type); expect(response.url).toEqual(''); @@ -264,7 +267,7 @@ test('no statusText', async () => { expect(response.ok).toEqual(true); expect(response.redirected).toEqual(redirected); expect(response.status).toEqual(200); - expect(response.statusText).toEqual(isWhatwgFetch ? undefined : ''); + expect(response.statusText).toEqual(emptyStatusText); expect(response.type).toEqual(type); expect(response.url).toEqual(''); @@ -288,7 +291,7 @@ if (isWhatwgFetch) { expect(response.ok).toEqual(false); expect(response.redirected).toEqual(redirected); expect(response.status).toEqual(0); - expect(response.statusText).toEqual(isWhatwgFetch ? undefined : ''); + expect(response.statusText).toEqual(emptyStatusText); expect(response.type).toEqual(type); expect(response.url).toEqual(''); @@ -308,7 +311,7 @@ if (isWhatwgFetch) { expect(response.ok).toEqual(false); expect(response.redirected).toEqual(redirected); expect(response.status).toEqual(0); - expect(response.statusText).toEqual(isWhatwgFetch ? undefined : ''); + expect(response.statusText).toEqual(emptyStatusText); expect(response.type).toEqual(type); expect(response.url).toEqual(''); @@ -327,7 +330,7 @@ if (isWhatwgFetch) { expect(response.ok).toEqual(false); expect(response.redirected).toEqual(redirected); expect(response.status).toEqual(0); - expect(response.statusText).toEqual(isWhatwgFetch ? undefined : ''); + expect(response.statusText).toEqual(emptyStatusText); expect(response.type).toEqual(type); expect(response.url).toEqual('');