Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change button disabling/incomplete error logic across client #293

Open
ssciolla opened this issue Jan 6, 2022 · 2 comments
Open

Change button disabling/incomplete error logic across client #293

ssciolla opened this issue Jan 6, 2022 · 2 comments
Labels
enhancement New feature or request front end Involves changes to the React application or other client-related files

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Jan 6, 2022

While working on #270, we've discussed the pros/cons of using button disabling to indicate whether the user still needs to complete something before they can proceed. We seem to have settled on the position that only disabling can be confusing to the user. Alternatively, it is probably more clear to allow all buttons to be clicked and then show error alerts where action needs to be taken.

Since we've adopted this alternative in the PR, it would be best to take this approach everywhere for consistency. The main places where disabling currently happens are with "Select Section" workflow steps, and in the "Merge Sections" feature.

Screen Shot 2022-01-06 at 12 11 32 PM

@ssciolla ssciolla added enhancement New feature or request front end Involves changes to the React application or other client-related files labels Jan 6, 2022
@ssciolla ssciolla self-assigned this Jan 6, 2022
@pushyamig
Copy link
Contributor

@ssciolla As understood from our discussion, this is Icebox issue?

@ssciolla
Copy link
Contributor Author

ssciolla commented Jan 6, 2022

@pushyamig, that's your call.

@ssciolla ssciolla removed their assignment Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front end Involves changes to the React application or other client-related files
Projects
None yet
Development

No branches or pull requests

2 participants