Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create global UI style/theme #75

Closed
chrisrrowland opened this issue May 5, 2021 · 8 comments · Fixed by #282
Closed

Create global UI style/theme #75

chrisrrowland opened this issue May 5, 2021 · 8 comments · Fixed by #282
Assignees
Labels
front end Involves changes to the React application or other client-related files
Projects

Comments

@chrisrrowland
Copy link
Contributor

chrisrrowland commented May 5, 2021

Not sure what the correct terminology but we should be using some sort of global theme/style throughout the application.

This seemed to me like something you might implement after having more than one feature so you have an idea of common concepts, though it couldn't hurt to have the framework in place earlier.

Currently each component is composing its own style.

We are using the MUI primary color as #00274C

@chrisrrowland chrisrrowland added good first issue Good for newcomers front end Involves changes to the React application or other client-related files labels May 5, 2021
@pushyamig
Copy link
Contributor

pushyamig commented Oct 25, 2021

This issue needs to be handled sooner or later since we have a error fires when clicking on certain feature, like create section
Screen Shot 2021-10-25 at 9 52 21 AM

@ssciolla
Copy link
Contributor

I looked at the findDOMNode issue very briefly, this seems to be the issue: iamhosseindhv/notistack#257

I will try updating Material UI, and otherwise I will try adding a ThemeProvider.

@pushyamig
Copy link
Contributor

pushyamig commented Oct 28, 2021

I will try updating Material UI, and otherwise I will try adding a ThemeProvider.

If upgrading to Material-UI fixes the error then We need to create a new issue since wrapping in a Theme is one way of fixing it. But the current issue description is not just about the error we are seeing.

@pushyamig
Copy link
Contributor

@ssciolla Can you provide some estimation here?

@ssciolla
Copy link
Contributor

ssciolla commented Dec 7, 2021

Well, it depends on what this issue is. If it's implementing a global theme, I can estimate that, but fixing the problem you identified may involve updating to Material UI 5, which is a bigger deal, harder to estimate. These should be split into separate issues.

@pushyamig
Copy link
Contributor

I am talking about the error, possible fix which I understood as having a global theme, if that is not the case. I feel we need to evaluate if we can live with this error for sometime or upgrade to Material UI.

@ssciolla
Copy link
Contributor

ssciolla commented Dec 7, 2021

Okay, I gave an estimate. I still think that needs to be a separate issue. It's related but not the same as what Chris originally opened this issue about.

@chrisrrowland
Copy link
Contributor Author

I believe I did some investigating, and that led to some article that led to me to experimenting w/ a theme to eliminate the warning message.
I don't remember why the theme solved it, but since we wanted to implement a global theme anyways it seemed like a reasonable solution.

@ssciolla ssciolla removed the good first issue Good for newcomers label Dec 8, 2021
pushyamig added a commit to pushyamig/canvas-course-manager-next that referenced this issue Dec 15, 2021
@pushyamig pushyamig added this to QA-Dev in 2022.01.01 Dec 16, 2021
2022.01.01 automation moved this from QA-Dev to QA Dec 16, 2021
@pushyamig pushyamig moved this from QA to QA-Dev in 2022.01.01 Dec 16, 2021
@zqian zqian linked a pull request Dec 20, 2021 that will close this issue
@zqian zqian moved this from QA-Dev to Done in 2022.01.01 Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front end Involves changes to the React application or other client-related files
Projects
No open projects
2022.01.01
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants