Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search not working properly for "in-place" #193

Open
agnivade opened this issue Jan 1, 2018 · 6 comments
Open

search not working properly for "in-place" #193

agnivade opened this issue Jan 1, 2018 · 6 comments
Labels
bug help wanted Open for new contributors to work on

Comments

@agnivade
Copy link
Member

agnivade commented Jan 1, 2018

Expected behaviour

On doing, tldr search in-place, I should get the sed page which has the word "in-place" in it.

Actual behaviour

$tldr search in-place
Searching for: in-place

    $ pbcopy (Available on: osx)
    $ pushd
    $ popd
    $ tldrl
    $ bc
    $ gofmt
    $ javac

Log, debug output

Environment

  • Operating system - Ubuntu 16.04
  • NodeJS version - 8.9.0
@agnivade
Copy link
Member Author

agnivade commented Jan 1, 2018

/cc @aero31aero - Can you take a look ?

@aero31aero
Copy link
Contributor

Sure. A bit busy post new year celebrations. Would take a look soon. An initial guess would be that the tokeniser is probably splitting in-place to just 'in' and we are losing all the relevant search data.

@aero31aero
Copy link
Contributor

Update: working on a small fix. Cannot find enough docs on natural to just use it, and a little hesitant to write my own tokenizing logic for maintainability concerns. I'll put up a WIP PR soon.

@agnivade
Copy link
Member Author

ping @aero31aero

@agnivade
Copy link
Member Author

friendly reminder :)

@agnivade
Copy link
Member Author

@aero31aero - Did you get a chance to work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Open for new contributors to work on
Projects
None yet
Development

No branches or pull requests

2 participants