Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-alias-page.py generates misleading pages #12747

Open
acuteenvy opened this issue May 6, 2024 · 2 comments
Open

set-alias-page.py generates misleading pages #12747

acuteenvy opened this issue May 6, 2024 · 2 comments
Labels
bug Issues with our clients or rendering of pages, etc. tooling Helper tools, scripts and automated processes.

Comments

@acuteenvy
Copy link
Member

The get_alias_page function doesn't do its job properly. This script then works on non-alias pages, and subsequently makes a huge mess by generating misleading pages. It also has some issues with page titles that contain spaces.

Examples: #11365.
Previous runs of this script:

set-alias-page.py should not be used until this is fixed.

@acuteenvy acuteenvy added bug Issues with our clients or rendering of pages, etc. tooling Helper tools, scripts and automated processes. labels May 6, 2024
@sebastiaanspeck
Copy link
Member

We could add a warning in the script to make people aware of this issue. Only mentioning here that the script should not be used, is too less visible for others

@sebastiaanspeck
Copy link
Member

We could add a warning in the script to make people aware of this issue. Only mentioning here that the script should not be used, is too less visible for others

I see that It already has a warning at the top of the script:

Disclaimer: This script generates a lot of false positives so it
isn't suggested to use the sync option. If used, only stage changes
and commit verified changes for your language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues with our clients or rendering of pages, etc. tooling Helper tools, scripts and automated processes.
Projects
None yet
Development

No branches or pull requests

2 participants