Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

fixes #459 #492

Conversation

pauloFernandes
Copy link

fixes #459

Apparently, there was an attribute for radioGroups called defaultChecked, when it had an onChange event related. Using this attribute, the radioGroup's internal state changes, but it doesn't reflect this change in the view (the default selected radio option still selected).

In this PR, I've removed the defaultChecked from RadioGroup, keeping only checked, which is really used in Radio Component.

@codecov-io
Copy link

Codecov Report

Merging #492 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/RadioGroup.js 100% <ø> (ø) ⬆️
src/__tests__/RadioGroup-test.js 97.5% <100%> (ø) ⬆️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio state not changing when component retrieved from state
2 participants