Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters crash silently, if no return is given. #100

Open
Sivli-Embir opened this issue Jun 27, 2013 · 0 comments
Open

Filters crash silently, if no return is given. #100

Sivli-Embir opened this issue Jun 27, 2013 · 0 comments

Comments

@Sivli-Embir
Copy link

I foolishly forgot to return page inside of a filter and the Chrome tab on OS X would completely hang and fail to quit. So much so that I required a few OS level restarts before I found my issue.

Will hang Chrome, possible other browsers as well.

Meteor.Router.filters({
'someFilter': function (page) {
    //return page;
  }
});

Works like a charm.

Meteor.Router.filters({
'someFilter': function (page) {
    return page;
  }
});

This is not a major issue but you may want to add a warning. Would be great if you could throw an exception when this happens.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant