New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeRouting reactivity #88

Open

zvictor opened this issue May 30, 2013 · 1 comment

Contributor

zvictor commented May 30, 2013

It seems to me that beforeRouting should run encapsulated by Deps.nonreactive.

Trying to run the following code leads me to a infinite loop due to the reactivity:

Meteor.Router.beforeRouting = function() {
  var history = Session.get("history");
  history.push(window.location);
  Session.set("history", history);
};

The text was updated successfully, but these errors were encountered:

littke commented Jun 26, 2013

I've got similar problems with infinite loops.

(I'm only setting Sessions within beforeRouting though, which I'm guessing shouldn't be a reactive data source.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment